Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 83443002: Handle surrogates in BidiResolver::determineParagraphDirectionality (Closed)

Created:
7 years, 1 month ago by fs
Modified:
7 years ago
CC:
blink-reviews, leviw_travelin_and_unemployed, igoroliveira
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Handle surrogates in BidiResolver::determineParagraphDirectionality TEST=unittest:BidiResolver.ParagraphDirectionSurrogates BUG=322051 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162915

Patch Set 1 #

Patch Set 2 : Fix scoping of String in unittest; rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -20 lines) Patch
M Source/platform/text/BidiResolver.h View 1 chunk +25 lines, -12 lines 0 comments Download
M Source/platform/text/BidiResolverTest.cpp View 1 2 chunks +53 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
fs
7 years, 1 month ago (2013-11-22 12:57:59 UTC) #1
eseidel
Crazy.
7 years, 1 month ago (2013-11-22 18:50:09 UTC) #2
eseidel
lgtm
7 years, 1 month ago (2013-11-22 18:50:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/83443002/1
7 years, 1 month ago (2013-11-22 18:51:22 UTC) #4
eseidel
Ideally we could test this with a layout test as well so we could compare ...
7 years, 1 month ago (2013-11-22 18:52:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) blink_platform_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=3756
7 years, 1 month ago (2013-11-22 19:27:43 UTC) #6
fs
On 2013/11/22 18:52:05, eseidel wrote: > Ideally we could test this with a layout test ...
7 years ago (2013-11-29 12:52:01 UTC) #7
fs
7 years ago (2013-11-29 14:58:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/83443002/170001
7 years ago (2013-11-29 15:59:49 UTC) #9
commit-bot: I haz the power
7 years ago (2013-11-29 16:44:42 UTC) #10
Message was sent while issue was closed.
Change committed as 162915

Powered by Google App Engine
This is Rietveld 408576698