Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 834423003: Disable Camera2 API for devices with legacy hardware support (Closed)

Created:
5 years, 11 months ago by magjed_chromium
Modified:
5 years, 10 months ago
Reviewers:
perkj_chrome, mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Camera2 API for devices with legacy hardware support BUG=446610 TBR=mcasas TEST=Add log statement in function isLegacyDevice and navigate to any page in chrome that uses the camera to verify that Nexus 4 is INFO_SUPPORTED_HARDWARE_LEVEL_LEGACY and Nexus 5 is INFO_SUPPORTED_HARDWARE_LEVEL_FULL. Committed: https://crrev.com/f62e6ae41bc9cb5c4d4ae78eda8e441a8a9ec657 Cr-Commit-Position: refs/heads/master@{#311047}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCaptureCamera2.java View 1 chunk +8 lines, -0 lines 1 comment Download
M media/base/android/java/src/org/chromium/media/VideoCaptureFactory.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
magjed_chromium
perkj - Can you take a look?
5 years, 11 months ago (2015-01-12 13:41:40 UTC) #3
perkj_chrome
lgtm but please add a TEST= and describe how to test and verify that Camera2 ...
5 years, 11 months ago (2015-01-12 13:51:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834423003/20001
5 years, 11 months ago (2015-01-12 14:08:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 11 months ago (2015-01-12 15:04:18 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f62e6ae41bc9cb5c4d4ae78eda8e441a8a9ec657 Cr-Commit-Position: refs/heads/master@{#311047}
5 years, 11 months ago (2015-01-12 15:05:08 UTC) #8
magjed_chromium
Miguel - Can you take a look at this? Maybe there is some better solution?
5 years, 10 months ago (2015-01-30 11:07:21 UTC) #10
mcasas
5 years, 10 months ago (2015-01-30 20:34:29 UTC) #11
Message was sent while issue was closed.
On 2015/01/30 11:07:21, magjed wrote:
> Miguel - Can you take a look at this? Maybe there is some better solution?

I tried new and old APIs for http://crbug.com/448457 and elsewhere and
see that N5 and N6 work fine with the new API, while N4 and N7 don't.
Of course this applies to Android 5.0+. 

This work/no work seems to correlate 100% with the LEGACY bit,
so I think this CL is the correct way to go. We should keep an eye
on all this though. It might change.

Powered by Google App Engine
This is Rietveld 408576698