fpdfsdk/src/fsdk_mgr.cpp - Issue 834413002: XFA: merge patch from CL 792953005, fix most VC++ warnings - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1564)

My Issues | Starred Open | Closed | All

Unified Diff: fpdfsdk/src/fsdk_mgr.cpp

Issue 834413002: XFA: merge patch from CL 792953005, fix most VC++ warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« fpdfsdk/include/fsdk_mgr.h ('K') | « fpdfsdk/src/fpdfformfill.cpp ('k') | pdfium.gyp » ('j') | xfa/src/fxfa/src/parser/xfa_localevalue.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: fpdfsdk/src/fsdk_mgr.cpp

diff --git a/fpdfsdk/src/fsdk_mgr.cpp b/fpdfsdk/src/fsdk_mgr.cpp

index c4cee6f4d82e808ab6b38863eb7a42ac84911d14..f134b790a931454e28ccb2f5a353ef6bb650a2b6 100644

--- a/fpdfsdk/src/fsdk_mgr.cpp

+++ b/fpdfsdk/src/fsdk_mgr.cpp

@@ -678,7 +678,10 @@ void CPDFSDK_PageView::PageView_OnDraw(CFX_RenderDevice* pDevice, CPDF_Matrix* p

gs.Create(pDevice);

if (pClip) {

CFX_RectF rectClip;

- rectClip.Set(pClip->left, pClip->top, pClip->Width(), pClip->Height());

+ rectClip.Set(static_cast<FX_FLOAT>(pClip->left),

+ static_cast<FX_FLOAT>(pClip->top),

+ static_cast<FX_FLOAT>(pClip->Width()),

+ static_cast<FX_FLOAT>(pClip->Height()));

gs.SetClipRect(rectClip);

}

IXFA_RenderContext* pRenderContext = XFA_RenderContext_Create();

« fpdfsdk/include/fsdk_mgr.h ('K') | « fpdfsdk/src/fpdfformfill.cpp ('k') | pdfium.gyp » ('j') | xfa/src/fxfa/src/parser/xfa_localevalue.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698