Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: src/ia32/ic-ia32.cc

Issue 8344045: Fast elements conversions in crankshaft using generated code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/ic-ia32.cc
diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc
index 4a12dc8565348535f0004a3395e7067a31415557..de51913672340e10ecb12d706371c61d59085ca4 100644
--- a/src/ia32/ic-ia32.cc
+++ b/src/ia32/ic-ia32.cc
@@ -1587,11 +1587,8 @@ void KeyedStoreIC::GenerateTransitionElementsSmiToDouble(MacroAssembler* masm) {
// -----------------------------------
// Must return the modified receiver in eax.
- __ pop(ebx);
- __ push(edx);
- __ push(ebx); // return address
-
- __ TailCallRuntime(Runtime::kTransitionElementsSmiToDouble, 1, 1);
+ FastElementsConversionStub::GenerateSmiOnlyToDouble(
+ masm, FastElementsConversionStub::TRANSITION_ONLY);
}
@@ -1603,11 +1600,8 @@ void KeyedStoreIC::GenerateTransitionElementsDoubleToObject(
// -----------------------------------
// Must return the modified receiver in eax.
- __ pop(ebx);
- __ push(edx);
- __ push(ebx); // return address
-
- __ TailCallRuntime(Runtime::kTransitionElementsDoubleToObject, 1, 1);
+ FastElementsConversionStub::GenerateDoubleToObject(
+ masm, FastElementsConversionStub::TRANSITION_ONLY);
}

Powered by Google App Engine
This is Rietveld 408576698