Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart

Issue 834383005: Don't perform incremental resolution if curly brackets are not balanced. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart b/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
index 2f9e3a0ce3cb950fe6ab4b6c4e06e70ebcdd274f..2b9afd0187f7f329e126d2da14a8b5c95e18fa98 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
@@ -781,6 +781,11 @@ class _SameResolutionValidator implements AstVisitor {
_visitNode(node.expression, other.expression);
}
+ void _assertNode(AstNode a, AstNode b) {
+ _expectEquals(a.offset, b.offset);
+ _expectEquals(a.length, b.length);
+ }
+
void _expectEquals(actual, expected) {
if (actual != expected) {
String message = '';
@@ -863,10 +868,12 @@ class _SameResolutionValidator implements AstVisitor {
}
void _visitExpression(Expression a, Expression b) {
+// print('[${a.offset}] |$a| vs. [${b.offset}] |$b|');
_verifyType(a.staticType, b.staticType);
_verifyType(a.propagatedType, b.propagatedType);
_verifyElement(a.staticParameterElement, b.staticParameterElement);
_verifyElement(a.propagatedParameterElement, b.propagatedParameterElement);
+ _assertNode(a, b);
}
void _visitList(NodeList nodeList, NodeList otherList) {
@@ -882,8 +889,7 @@ class _SameResolutionValidator implements AstVisitor {
_expectIsNull(other);
} else {
this.other = other;
- _expectEquals(node.offset, other.offset);
- _expectEquals(node.length, other.length);
+ _assertNode(node, other);
node.accept(this);
}
}

Powered by Google App Engine
This is Rietveld 408576698