Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 834373002: ozone: xkb: Fix number pad key mappings (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 11 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: xkb: Fix number pad key mappings ChromeOS doesn't have toggleable num lock; it is always considered enabled. Always set num lock in the xkb modifier mask. BUG=34920 TEST=numpad on link_freon generates numbers Committed: https://crrev.com/5da247c99d4ab16225ac3f61ad137afff094d632 Cr-Commit-Position: refs/heads/master@{#310152}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 4 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
spang
5 years, 11 months ago (2015-01-06 20:31:22 UTC) #2
kpschoedel
lgtm
5 years, 11 months ago (2015-01-06 20:41:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834373002/1
5 years, 11 months ago (2015-01-06 20:42:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/110172) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/46132) android_arm64_dbg_recipe ...
5 years, 11 months ago (2015-01-06 20:46:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834373002/20001
5 years, 11 months ago (2015-01-06 20:51:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 21:54:51 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 21:56:33 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5da247c99d4ab16225ac3f61ad137afff094d632
Cr-Commit-Position: refs/heads/master@{#310152}

Powered by Google App Engine
This is Rietveld 408576698