Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 834323006: Revert "Lint contribution refactoring.", r42967 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index ae4bdedc002835ae42e503e31d919828ce1e07b7..a15a7e1a942a951056c0348c6225df693ad9762b 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -8,6 +8,7 @@ import "dart:math" as math;
import 'dart:collection';
import 'package:analyzer/src/generated/utilities_collection.dart';
+import 'package:analyzer/src/generated/visitors.dart';
import 'ast.dart';
import 'constant.dart';
@@ -9201,6 +9202,56 @@ class LibraryScope extends EnclosedScope {
}
}
+/// Implementers contribute lint warnings via the provided error [reporter].
+abstract class Linter {
+ /// Used to report lint warnings.
+ /// NOTE: this is set by the framework before visit begins.
+ ErrorReporter reporter;
+
+ /// Return a visitor to be passed to compilation units to perform lint
+ /// analysis.
+ /// Lint errors are reported via this [Linter]'s error [reporter].
+ AstVisitor getVisitor();
+}
+
+/// Traverses a library's worth of dart code at a time to generate lint warnings
+/// over the set of sources.
+///
+/// See [LintCode].
+class LintGenerator {
+
+ /// A global container for contributed linters.
+ static final List<Linter> LINTERS = <Linter>[];
+
+ final Iterable<CompilationUnit> _compilationUnits;
+ final AnalysisErrorListener _errorListener;
+ final Iterable<Linter> _linters;
+
+ LintGenerator(this._compilationUnits, this._errorListener,
+ [Iterable<Linter> linters])
+ : _linters = linters != null ? linters : LINTERS;
+
+ void generate() {
+ TimeCounter_TimeCounterHandle timeCounter =
+ PerformanceStatistics.lint.start();
+ try {
+ _compilationUnits.forEach((cu) {
+ if (cu.element != null) {
+ _generate(cu, cu.element.source);
+ }
+ });
+ } finally {
+ timeCounter.stop();
+ }
+ }
+
+ void _generate(CompilationUnit unit, Source source) {
+ ErrorReporter errorReporter = new ErrorReporter(_errorListener, source);
+ _linters.forEach((l) => l.reporter = errorReporter);
+ Iterable<AstVisitor> visitors = _linters.map((l) => l.getVisitor());
+ unit.accept(new DelegatingAstVisitor(visitors.where((v) => v != null)));
+ }
+}
/**
* This class is used to replace uses of `HashMap<String, ExecutableElement>` which are not as
« no previous file with comments | « pkg/analyzer/lib/src/generated/incremental_resolver.dart ('k') | pkg/analyzer/lib/src/generated/visitors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698