Fix tabIndex in chrome://settings/passwords

chrome/browser/resources/options/password_manager_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.passwordManager', function() {
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var List = cr.ui.List;
 
@@ skipping 51 matching lines @@
       this.contentElement.appendChild(usernameLabel);
 
       // The stored password.
       var passwordInputDiv = this.ownerDocument.createElement('div');
       passwordInputDiv.className = 'password';
 
       // The password input field.
       var passwordInput = this.ownerDocument.createElement('input');
       passwordInput.type = 'password';
       passwordInput.className = 'inactive-password';
+      this.closeButtonElement.tabIndex = -1;
+      passwordInput.tabIndex = -1;

[Dan Beam, 2015/01/22 00:39:59]

make a

  setFocusable: function(focusable) {
    var tabIndex = focusable ? 0 : -1;
    this.closeButtonElement.tabIndex = this.passwordField = tabIndex;
  },

and reuse from various places

       passwordInput.readOnly = true;
       passwordInput.value = this.showPasswords_ ? this.password : '********';
       passwordInputDiv.appendChild(passwordInput);
       this.passwordField = passwordInput;
 
       // The show/hide button.
       if (this.showPasswords_) {
         var button = this.ownerDocument.createElement('button');
         button.hidden = true;
         button.className = 'list-inline-button custom-appearance';
@@ skipping 14 matching lines @@
 
     /** @override */
     selectionChanged: function() {
       var input = this.passwordField;
       var button = this.passwordShowButton;
       // The button doesn't exist when passwords can't be shown.
       if (!button)
         return;
 
       if (this.selected) {
+        input.focus();

[Dan Beam, 2015/01/22 00:39:59]

you should set the tabIndex = 0 before trying to focus().  i'm surprised this
works (if it does).

         input.classList.remove('inactive-password');
+        input.tabIndex = 0;
+        this.closeButtonElement.tabIndex = 0;

[Dan Beam, 2015/01/22 00:39:59]

nit: arguably:

input.tabIndex = this.closeButtonElement.tabIndex = 0;

         button.hidden = false;
       } else {
         input.classList.add('inactive-password');
+        input.tabIndex = -1;
+        this.closeButtonElement.tabIndex = -1;

[Dan Beam, 2015/01/22 00:39:59]

nit: arguably

this.closeButtonElement.tabIndex = input.tabIndex = -1;

         button.hidden = true;
       }
     },
 
     /**
      * Reveals the plain text password of this entry.
      */
     showPassword: function(password) {
       this.passwordField.value = password;
       this.passwordField.type = 'text';
@@ skipping 222 matching lines @@
     },
   };
 
   return {
     PasswordListItem: PasswordListItem,
     PasswordExceptionsListItem: PasswordExceptionsListItem,
     PasswordsList: PasswordsList,
     PasswordExceptionsList: PasswordExceptionsList,
   };
 });