Factor out checkerboard function in gm and sampleapp into tools.

Factor out checkerboard function in gm and sampleapp into tools.

Committed: https://skia.googlesource.com/skia/+/878fa0204bc246ec5fbaca4aa3c81aaefccc30a1

[hal.canary, 2015-01-06 22:25:21]

halcanary@google.com changed reviewers:
+ djsollen@google.com

[hal.canary, 2015-01-06 22:25:22]

ptal

[djsollen, 2015-01-07 16:24:21]

https://codereview.chromium.org/834303005/diff/20001/gm/checkerboard.h
File gm/checkerboard.h (right):

https://codereview.chromium.org/834303005/diff/20001/gm/checkerboard.h#newcode2
gm/checkerboard.h:2: * Copyright 2015 Google Inc.
move to tools and make the checkerboard changes in a separate CL.

[hal.canary, 2015-01-07 20:08:33]

halcanary@google.com changed reviewers:
+ reed@google.com

[hal.canary, 2015-01-07 20:08:59]

checkerboard-only CL.

[tfarina, 2015-01-07 20:15:48]

https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h
File tools/Checkerboard.h (right):

https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h#new...
tools/Checkerboard.h:2: * Copyright 2015 Google Inc.
Shouldn't this be Skia Authors rather than Google Inc.?

[hal.canary, 2015-01-07 20:34:36]

On 2015/01/07 20:15:48, tfarina wrote:
> https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h
> File tools/Checkerboard.h (right):
> 
>
https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h#new...
> tools/Checkerboard.h:2: * Copyright 2015 Google Inc.
> Shouldn't this be Skia Authors rather than Google Inc.?

We have some of everything in the repository.  Here's a quick count:

      3 Copyright YEAR ARM Ltd.
   1582 Copyright YEAR Google Inc.
      2 Copyright YEAR Intel Inc.
      3 Copyright YEAR Mozilla Foundation
      4 Copyright YEAR Skia
    566 Copyright YEAR The Android Open Source Project
     82 Copyright YEAR The Chromium Authors.

[hal.canary, 2015-01-26 17:13:21]

halcanary@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2015-01-26 18:56:31]

https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h
File tools/Checkerboard.h (right):

https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h#new...
tools/Checkerboard.h:22: void Checkerboard(SkCanvas* canvas, SkColor color1,
SkColor color2, int size);
lgtm, but maybe rename this function to be a bit more descriptive, e.g.
FillCheckerboard, ClearWithCheckerboard(), ...

[hal.canary, 2015-01-26 19:01:00]

https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h
File tools/Checkerboard.h (right):

https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h#new...
tools/Checkerboard.h:22: void Checkerboard(SkCanvas* canvas, SkColor color1,
SkColor color2, int size);
On 2015/01/26 18:56:31, bsalomon wrote:
> lgtm, but maybe rename this function to be a bit more descriptive, e.g.
> FillCheckerboard, ClearWithCheckerboard(), ...

DrawWithCheckerboard() ?

[bsalomon, 2015-01-26 19:08:31]

On 2015/01/26 19:01:00, Hal Canary wrote:
> https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h
> File tools/Checkerboard.h (right):
> 
>
https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h#new...
> tools/Checkerboard.h:22: void Checkerboard(SkCanvas* canvas, SkColor color1,
> SkColor color2, int size);
> On 2015/01/26 18:56:31, bsalomon wrote:
> > lgtm, but maybe rename this function to be a bit more descriptive, e.g.
> > FillCheckerboard, ClearWithCheckerboard(), ...
> 
> DrawWithCheckerboard() ?

Howabout simply DrawCheckerboard()?

[hal.canary, 2015-01-26 19:09:13]

On 2015/01/26 19:08:31, bsalomon wrote:
> On 2015/01/26 19:01:00, Hal Canary wrote:
> > https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h
> > File tools/Checkerboard.h (right):
> > 
> >
>
https://codereview.chromium.org/834303005/diff/40001/tools/Checkerboard.h#new...
> > tools/Checkerboard.h:22: void Checkerboard(SkCanvas* canvas, SkColor color1,
> > SkColor color2, int size);
> > On 2015/01/26 18:56:31, bsalomon wrote:
> > > lgtm, but maybe rename this function to be a bit more descriptive, e.g.
> > > FillCheckerboard, ClearWithCheckerboard(), ...
> > 
> > DrawWithCheckerboard() ?
> 
> Howabout simply DrawCheckerboard()?

that's it.

[hal.canary, 2015-01-26 19:11:19]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-01-26 19:12:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/834303005/80001

[commit-bot: I haz the power, 2015-01-26 19:24:35]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/878fa0204bc246ec5fbaca4aa3c81aaefccc30a1