Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 834303002: use conics for ovals and roundrects (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
egdaniel, reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use conics for ovals and roundrects This reverts commit e3b61eb7997d12c5f9b844dd3af1847492d9f411. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/9810cd25ce3d2de1496bbdf6317cd22d1dcc8794

Patch Set 1 #

Patch Set 2 : apply fix to edgebuilder #

Patch Set 3 : land fixes in separate CLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -5 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +87 lines, -0 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
reed1
5 years, 11 months ago (2015-01-06 15:21:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834303002/40001
5 years, 11 months ago (2015-01-07 00:16:11 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 00:26:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9810cd25ce3d2de1496bbdf6317cd22d1dcc8794

Powered by Google App Engine
This is Rietveld 408576698