Define the glibc specific functions for OpenBSD too

Define the glibc specific functions for OpenBSD too


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106118

[Robert Nagy, 2011-10-18 18:02:39]

Please review the following patch for OpenBSD.

Thank you

[Mark Mentovai, 2011-10-18 18:09:15]

http://codereview.chromium.org/8343007/diff/1/third_party/leveldatabase/env_c...
File third_party/leveldatabase/env_chromium.cc (right):

http://codereview.chromium.org/8343007/diff/1/third_party/leveldatabase/env_c...
third_party/leveldatabase/env_chromium.cc:1: // Copyright (c) 2011 The LevelDB
Authors. All rights reserved.
README.chromium! You need to state that this is a local modification. This is
important any time you make changes to code pulled from elsewhere. It’s not
optional.

Better yet, contribute your change upstream and import a new version into
Chromium.

I’m adding hans@chromium.org because he’s a leveldb committer.

[Mark Mentovai, 2011-10-18 18:09:46]

I didn’t add hans because dgrogan is a leveldb committer and can help.

[Robert Nagy, 2011-10-18 18:13:29]

On 2011/10/18 18:09:15, Mark Mentovai wrote:
>
http://codereview.chromium.org/8343007/diff/1/third_party/leveldatabase/env_c...
> File third_party/leveldatabase/env_chromium.cc (right):
> 
>
http://codereview.chromium.org/8343007/diff/1/third_party/leveldatabase/env_c...
> third_party/leveldatabase/env_chromium.cc:1: // Copyright (c) 2011 The LevelDB
> Authors. All rights reserved.
> README.chromium! You need to state that this is a local modification. This is
> important any time you make changes to code pulled from elsewhere. It’s not
> optional.
> 
> Better yet, contribute your change upstream and import a new version into
> Chromium.
> 
> I’m adding mailto:hans@chromium.org because he’s a leveldb committer.


Ah sorry about that again. I will probably make a hang of this pretty soon :)

I've added a comment about the local modification and I will also submit the
patch for upstream.

[Mark Mentovai, 2011-10-18 18:14:04]

I’m putting this one on ice for the moment, since it’ll probably be easy to get
something into the upstream, and then we can just import that.

[Robert Nagy, 2011-10-18 18:16:33]

On 2011/10/18 18:14:04, Mark Mentovai wrote:
> I’m putting this one on ice for the moment, since it’ll probably be easy to
get
> something into the upstream, and then we can just import that.

Looking at the upstream version, they are missing the android define too.

[Mark Mentovai, 2011-10-18 18:18:44]

Can we get that back up to them too? The fewer differences we need to maintain
locally, the better off we’ll be.

[Robert Nagy, 2011-10-18 18:20:20]

On 2011/10/18 18:16:33, Robert Nagy wrote:
> On 2011/10/18 18:14:04, Mark Mentovai wrote:
> > I’m putting this one on ice for the moment, since it’ll probably be easy to
> get
> > something into the upstream, and then we can just import that.
> 
> Looking at the upstream version, they are missing the android define too.

Actually, I can't even find that file in their repository, because they removed
it:

- Removing Chromium-specific files.
  They are now going to live in the Chromium repository.

[Mark Mentovai, 2011-10-18 18:22:31]

Oh, OK. I guess README.chromium already says that this file is Chromium-specific
(although it’s not clear that the files are *added* and not just *modified* in
some way). You can revert your change to README.chromium and I’ll LG this.

[Robert Nagy, 2011-10-18 18:29:40]

On 2011/10/18 18:22:31, Mark Mentovai wrote:
> Oh, OK. I guess README.chromium already says that this file is
Chromium-specific
> (although it’s not clear that the files are *added* and not just *modified* in
> some way). You can revert your change to README.chromium and I’ll LG this.

done

[Mark Mentovai, 2011-10-18 18:42:26]

LGTM

[commit-bot: I haz the power, 2011-10-18 18:42:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8343007/7002

[commit-bot: I haz the power, 2011-10-18 20:31:30]

Change committed as 106118

[dgrogan, 2011-10-18 20:36:05]

Thanks for fixing this.