Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 834213002: Chromecast: forcibly trigger GC in low-memory situations. (Closed)

Created:
5 years, 11 months ago by gunsch
Modified:
5 years, 11 months ago
Reviewers:
lcwu1, ghines
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: forcibly trigger GC in low-memory situations. R=lcwu@chromium.org,ghines@chromium.org BUG=336640 Committed: https://crrev.com/5751172700f69b771970e05c62ec335be5531cfc Cr-Commit-Position: refs/heads/master@{#310572}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M chromecast/renderer/cast_content_renderer_client.cc View 1 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
gunsch
5 years, 11 months ago (2015-01-06 01:41:59 UTC) #1
lcwu1
lgtm % adding a TODO. https://codereview.chromium.org/834213002/diff/1/chromecast/renderer/cast_content_renderer_client.cc File chromecast/renderer/cast_content_renderer_client.cc (right): https://codereview.chromium.org/834213002/diff/1/chromecast/renderer/cast_content_renderer_client.cc#newcode35 chromecast/renderer/cast_content_renderer_client.cc:35: const int kPollingIntervalMS = ...
5 years, 11 months ago (2015-01-08 18:52:12 UTC) #2
gunsch
https://codereview.chromium.org/834213002/diff/1/chromecast/renderer/cast_content_renderer_client.cc File chromecast/renderer/cast_content_renderer_client.cc (right): https://codereview.chromium.org/834213002/diff/1/chromecast/renderer/cast_content_renderer_client.cc#newcode35 chromecast/renderer/cast_content_renderer_client.cc:35: const int kPollingIntervalMS = 5000; On 2015/01/08 18:52:12, lcwu1 ...
5 years, 11 months ago (2015-01-08 19:02:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834213002/20001
5 years, 11 months ago (2015-01-08 19:55:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-08 19:57:11 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:58:11 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5751172700f69b771970e05c62ec335be5531cfc
Cr-Commit-Position: refs/heads/master@{#310572}

Powered by Google App Engine
This is Rietveld 408576698