Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 8342055: Added some comments and a warning message to pyauto perf tests in perf.py. (Closed)

Created:
9 years, 2 months ago by dennis_jeffrey
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Added some comments and a warning message to pyauto perf tests in perf.py. Since performance key values (descriptions) are truncated to 30 characters before they are stored into the autotest database, a warning message is now printed in perf.py in the event that a perf description > length 30 is outputted. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106457

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M chrome/test/functional/perf.py View 1 6 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dennis_jeffrey
9 years, 2 months ago (2011-10-19 22:23:54 UTC) #1
truty
lgtm http://codereview.chromium.org/8342055/diff/1/chrome/test/functional/perf.py File chrome/test/functional/perf.py (right): http://codereview.chromium.org/8342055/diff/1/chrome/test/functional/perf.py#newcode129 chrome/test/functional/perf.py:129: '(length 30) when added to the autotest database.' ...
9 years, 2 months ago (2011-10-20 00:12:01 UTC) #2
dennis_jeffrey
Thanks, submitting now. http://codereview.chromium.org/8342055/diff/1/chrome/test/functional/perf.py File chrome/test/functional/perf.py (right): http://codereview.chromium.org/8342055/diff/1/chrome/test/functional/perf.py#newcode129 chrome/test/functional/perf.py:129: '(length 30) when added to the ...
9 years, 2 months ago (2011-10-20 01:18:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dennisjeffrey@chromium.org/8342055/3001
9 years, 2 months ago (2011-10-20 01:18:30 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-10-20 05:28:08 UTC) #5
Change committed as 106457

Powered by Google App Engine
This is Rietveld 408576698