chrome/browser/ui/find_bar/find_bar_host_browsertest.cc - Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/browser/ui/find_bar/find_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/find_bar/find_bar_host_browsertest.cc

===================================================================

--- chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (revision 106380)

+++ chrome/browser/ui/find_bar/find_bar_host_browsertest.cc (working copy)

@@ -21,6 +21,7 @@

#include "content/browser/renderer_host/render_view_host.h"

#include "content/browser/tab_contents/tab_contents.h"

#include "content/browser/tab_contents/tab_contents_view.h"

+#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_types.h"

#include "net/test/test_server.h"

#include "ui/base/keycodes/keyboard_codes.h"

@@ -1061,7 +1062,8 @@

Profile* incognito_profile = browser()->profile()->GetOffTheRecordProfile();

Browser* incognito_browser = Browser::Create(incognito_profile);

ui_test_utils::WindowedNotificationObserver observer(

- content::NOTIFICATION_LOAD_STOP, NotificationService::AllSources());

+ content::NOTIFICATION_LOAD_STOP,

+ content::NotificationService::AllSources());

incognito_browser->AddSelectedTabWithURL(

url, content::PAGE_TRANSITION_START_PAGE);

observer.Wait();

@@ -1120,7 +1122,8 @@

params.initial_bounds = gfx::Rect(0, 0, 250, 500);

Browser* popup = Browser::CreateWithParams(params);

ui_test_utils::WindowedNotificationObserver observer(

- content::NOTIFICATION_LOAD_STOP, NotificationService::AllSources());

+ content::NOTIFICATION_LOAD_STOP,

+ content::NotificationService::AllSources());

popup->AddSelectedTabWithURL(GURL(chrome::kAboutBlankURL),

content::PAGE_TRANSITION_LINK);

// Wait for the page to finish loading.