chrome/browser/oom_priority_manager_browsertest.cc - Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/oom_priority_manager_browsertest.cc

Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/oom_priority_manager.cc ('k') | chrome/browser/password_manager/password_store_default.cc » ('j') | content/browser/notification_service_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/oom_priority_manager_browsertest.cc

===================================================================

--- chrome/browser/oom_priority_manager_browsertest.cc (revision 106237)

+++ chrome/browser/oom_priority_manager_browsertest.cc (working copy)

@@ -20,21 +20,24 @@

using namespace ui_test_utils;

// Get three tabs open. Load asynchronously to speed up the test.

- WindowedNotificationObserver load1(content::NOTIFICATION_LOAD_STOP,

- NotificationService::AllSources());

+ WindowedNotificationObserver load1(

+ content::NOTIFICATION_LOAD_STOP,

+ content::NotificationService::AllSources());

OpenURLParams open1(GURL("chrome://about"), GURL(),

CURRENT_TAB, content::PAGE_TRANSITION_TYPED, false);

browser()->OpenURL(open1);

- WindowedNotificationObserver load2(content::NOTIFICATION_LOAD_STOP,

- NotificationService::AllSources());

+ WindowedNotificationObserver load2(

+ content::NOTIFICATION_LOAD_STOP,

+ content::NotificationService::AllSources());

OpenURLParams open2(GURL("chrome://credits"), GURL(),

NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_TYPED,

false);

browser()->OpenURL(open2);

- WindowedNotificationObserver load3(content::NOTIFICATION_LOAD_STOP,

- NotificationService::AllSources());

+ WindowedNotificationObserver load3(

+ content::NOTIFICATION_LOAD_STOP,

+ content::NotificationService::AllSources());

OpenURLParams open3(GURL("chrome://terms"), GURL(),

NEW_FOREGROUND_TAB, content::PAGE_TRANSITION_TYPED,

false);

@@ -71,8 +74,9 @@

EXPECT_FALSE(g_browser_process->oom_priority_manager()->DiscardTab());

// Select the first tab. It should reload.

- WindowedNotificationObserver reload1(content::NOTIFICATION_LOAD_STOP,

- NotificationService::AllSources());

+ WindowedNotificationObserver reload1(

+ content::NOTIFICATION_LOAD_STOP,

+ content::NotificationService::AllSources());

browser()->SelectNumberedTab(0);

reload1.Wait();

EXPECT_FALSE(browser()->IsTabDiscarded(0));