chrome/browser/extensions/extension_install_ui.cc - Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_input_method_apitest.cc ('k') | chrome/browser/extensions/extension_management_api.cc » ('j') | content/browser/notification_service_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_ui.cc

===================================================================

--- chrome/browser/extensions/extension_install_ui.cc (revision 106237)

+++ chrome/browser/extensions/extension_install_ui.cc (working copy)

@@ -33,7 +33,7 @@

#include "chrome/common/extensions/extension_resource.h"

#include "chrome/common/extensions/url_pattern.h"

#include "chrome/common/url_constants.h"

-#include "content/common/notification_service.h"

+#include "content/public/browser/notification_service.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

@@ -323,10 +323,11 @@

case PERMISSIONS_PROMPT:

case RE_ENABLE_PROMPT:

case INSTALL_PROMPT: {

- NotificationService* service = NotificationService::current();

+ content::NotificationService* service =

+ content::NotificationService::current();

service->Notify(chrome::NOTIFICATION_EXTENSION_WILL_SHOW_CONFIRM_DIALOG,

content::Source<ExtensionInstallUI>(this),

- NotificationService::NoDetails());

+ content::NotificationService::NoDetails());

Prompt prompt(prompt_type_);

prompt.SetPermissions(permissions_->GetWarningMessages());

@@ -347,7 +348,7 @@

browser->GetSingletonTabNavigateParams(GURL(chrome::kChromeUINewTabURL));

browser::Navigate(&params);

- NotificationService::current()->Notify(

+ content::NotificationService::current()->Notify(

chrome::NOTIFICATION_APP_INSTALLED_TO_NTP,

content::Source<TabContents>(params.target_contents->tab_contents()),

content::Details<const std::string>(&app_id));