chrome/browser/extensions/browser_action_apitest.cc - Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_action_apitest.cc

Issue 8342048: Make NotificationService an interface in the content namespace, and switch callers to use it. Mov... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/apps_promo.cc ('k') | chrome/browser/extensions/convert_web_app_browsertest.cc » ('j') | content/browser/notification_service_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_action_apitest.cc

===================================================================

--- chrome/browser/extensions/browser_action_apitest.cc (revision 106237)

+++ chrome/browser/extensions/browser_action_apitest.cc (working copy)

@@ -21,6 +21,7 @@

#include "chrome/common/url_constants.h"

#include "chrome/test/base/ui_test_utils.h"

#include "content/browser/tab_contents/tab_contents.h"

+#include "content/public/browser/notification_service.h"

#include "ui/gfx/rect.h"

#include "ui/gfx/size.h"

@@ -38,7 +39,7 @@

ResultCatcher catcher;

ui_test_utils::WindowedNotificationObserver popup_observer(

chrome::NOTIFICATION_EXTENSION_POPUP_VIEW_READY,

- NotificationService::AllSources());

+ content::NotificationService::AllSources());

GetBrowserActionsBar().Press(index);

popup_observer.Wait();

EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();

@@ -397,7 +398,7 @@

ui_test_utils::WindowedNotificationObserver host_destroyed_observer(

chrome::NOTIFICATION_EXTENSION_HOST_DESTROYED,

- NotificationService::AllSources());

+ content::NotificationService::AllSources());

// Click the browser action.

browser()->profile()->GetExtensionService()->browser_event_router()->