Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 834173002: Add null check in LocationIconDecoration::OnMousePressed. (Closed)

Created:
5 years, 11 months ago by Charlie Reis
Modified:
5 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null check in LocationIconDecoration::OnMousePressed. BUG=445788 TEST=window.open(""), then click page info icon. Committed: https://crrev.com/f328a3db0a43b6f58ad85e5aae8a3715b64eeff1 Cr-Commit-Position: refs/heads/master@{#309975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Charlie Reis
Avi, can you take a look? Looks like the old check was removed here: https://codereview.chromium.org/287543002 ...
5 years, 11 months ago (2015-01-05 21:31:21 UTC) #2
Avi (use Gerrit)
LGTM
5 years, 11 months ago (2015-01-05 21:39:24 UTC) #3
Charlie Reis
On 2015/01/05 21:39:24, Avi wrote: > LGTM Thanks. I didn't see an easy way to ...
5 years, 11 months ago (2015-01-05 22:03:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834173002/1
5 years, 11 months ago (2015-01-05 22:04:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-05 22:52:53 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 22:53:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f328a3db0a43b6f58ad85e5aae8a3715b64eeff1
Cr-Commit-Position: refs/heads/master@{#309975}

Powered by Google App Engine
This is Rietveld 408576698