Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 834153003: Remove usage of [Client=..] from web_ui_mojo test. (Closed)

Created:
5 years, 11 months ago by darin (slow to review)
Modified:
5 years, 11 months ago
Reviewers:
Tom Sepez, jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of [Client=..] from web_ui_mojo test. Committed: https://crrev.com/33316c8af62f9e907594df09cd827d0030f02c82 Cr-Commit-Position: refs/heads/master@{#311306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -46 lines) Patch
M content/browser/webui/web_ui_mojo_browsertest.cc View 4 chunks +9 lines, -21 lines 0 comments Download
M content/test/data/web_ui_mojo.js View 1 chunk +8 lines, -19 lines 0 comments Download
M content/test/data/web_ui_test_mojo_bindings.mojom View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
darin (slow to review)
5 years, 11 months ago (2015-01-13 18:40:25 UTC) #2
darin (slow to review)
5 years, 11 months ago (2015-01-13 18:40:26 UTC) #3
jamesr
lgtm (another way would be to just have Ping() => () and then close the ...
5 years, 11 months ago (2015-01-13 18:57:51 UTC) #4
darin (slow to review)
On 2015/01/13 18:57:51, jamesr wrote: > lgtm > > (another way would be to just ...
5 years, 11 months ago (2015-01-13 19:25:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834153003/1
5 years, 11 months ago (2015-01-13 19:27:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-13 19:31:02 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 19:32:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33316c8af62f9e907594df09cd827d0030f02c82
Cr-Commit-Position: refs/heads/master@{#311306}

Powered by Google App Engine
This is Rietveld 408576698