Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart

Issue 834133002: dart2js OldEmitter: Small cleanups in output. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Added check for using Function.apply. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
index a681f7685c27c208b708866c4b1a6153cba43c81..af179f8b996b73040b0ffbb405e2d1baf46d2b3f 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/reflection_data_parser.dart
@@ -234,7 +234,6 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
requiredParameterCount + optionalParameterCount != funcs[0].length;
var functionTypeIndex = ${readFunctionType("array", "2")};
var unmangledNameIndex = $unmangledNameIndex;
- var isReflectable = array.length > unmangledNameIndex;
if (getterStubName) {
f = tearOff(funcs, array, isStatic, name, isIntercepted);
@@ -249,32 +248,38 @@ jsAst.Expression getReflectionDataParser(OldEmitter oldEmitter,
f.\$callName = null;
if (isIntercepted) #interceptedNames[getterStubName] = true;
}
- if (isReflectable) {
- for (var i = 0; i < funcs.length; i++) {
- funcs[i].$reflectableField = 1;
- funcs[i].$reflectionInfoField = array;
- }
- var mangledNames = isStatic ? #mangledGlobalNames : #mangledNames;
- var unmangledName = ${readString("array", "unmangledNameIndex")};
- // The function is either a getter, a setter, or a method.
- // If it is a method, it might also have a tear-off closure.
- // The unmangledName is the same as the getter-name.
- var reflectionName = unmangledName;
- if (getterStubName) mangledNames[getterStubName] = reflectionName;
- if (isSetter) {
- reflectionName += "=";
- } else if (!isGetter) {
- reflectionName += ":" + requiredParameterCount +
- ":" + optionalParameterCount;
+
+ if (#usesMangledNames) {
+ var isReflectable = array.length > unmangledNameIndex;
+ if (isReflectable) {
+ for (var i = 0; i < funcs.length; i++) {
+ funcs[i].$reflectableField = 1;
+ funcs[i].$reflectionInfoField = array;
+ }
+ var mangledNames = isStatic ? #mangledGlobalNames : #mangledNames;
+ var unmangledName = ${readString("array", "unmangledNameIndex")};
+ // The function is either a getter, a setter, or a method.
+ // If it is a method, it might also have a tear-off closure.
+ // The unmangledName is the same as the getter-name.
+ var reflectionName = unmangledName;
+ if (getterStubName) mangledNames[getterStubName] = reflectionName;
+ if (isSetter) {
+ reflectionName += "=";
+ } else if (!isGetter) {
+ reflectionName += ":" + requiredParameterCount +
+ ":" + optionalParameterCount;
+ }
+ mangledNames[name] = reflectionName;
+ funcs[0].$reflectionNameField = reflectionName;
+ funcs[0].$metadataIndexField = unmangledNameIndex + 1;
+ if (optionalParameterCount) descriptor[unmangledName + "*"] = funcs[0];
}
- mangledNames[name] = reflectionName;
- funcs[0].$reflectionNameField = reflectionName;
- funcs[0].$metadataIndexField = unmangledNameIndex + 1;
- if (optionalParameterCount) descriptor[unmangledName + "*"] = funcs[0];
}
}
''', {'globalFunctions' : globalFunctionsAccess,
'interceptedNames': interceptedNamesAccess,
+ 'usesMangledNames':
+ compiler.mirrorsLibrary != null || compiler.enabledFunctionApply,
'mangledGlobalNames': mangledGlobalNamesAccess,
'mangledNames': mangledNamesAccess});
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698