Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 83413004: Remove enable Drive offline system tray UI. (Closed)

Created:
7 years, 1 month ago by Tim Song
Modified:
7 years, 1 month ago
Reviewers:
James Cook, jennyz, achuithb
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove enable Drive offline system tray UI. BUG=322409 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236859

Patch Set 1 #

Patch Set 2 : drive settings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -367 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/ash_strings.grd View 1 chunk +0 lines, -9 lines 0 comments Download
D ash/system/chromeos/drive/tray_drive_notice.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ash/system/chromeos/drive/tray_drive_notice.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D ash/system/chromeos/drive/tray_drive_unittest.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M ash/system/drive/drive_observer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/drive/tray_drive.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/drive/tray_drive.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/system_tray_notifier.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tim Song
The UX design for this feature has changed, and this code is no longer needed. ...
7 years, 1 month ago (2013-11-22 19:22:56 UTC) #1
achuithb
On 2013/11/22 19:22:56, Tim Song wrote: > The UX design for this feature has changed, ...
7 years, 1 month ago (2013-11-22 19:40:38 UTC) #2
jennyz
lgtm
7 years, 1 month ago (2013-11-22 19:47:34 UTC) #3
James Cook
lgtm
7 years, 1 month ago (2013-11-22 20:49:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/83413004/30001
7 years, 1 month ago (2013-11-22 20:50:42 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 23:06:09 UTC) #6
Message was sent while issue was closed.
Change committed as 236859

Powered by Google App Engine
This is Rietveld 408576698