Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 83413003: Fixed regression in about:policy from revision 235005. (Closed)

Created:
7 years, 1 month ago by Joao da Silva
Modified:
7 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed regression in about:policy from revision 235005. The Profile's PolicyService does not include the DeviceCloudPolicyManager since https://codereview.chromium.org/60823003, but about:policy reads policy data from that service. This change adds the DeviceCloudPolicyManager to the Profile's PolicyService too, but unlike the platform provide it is not wrapped by a ForwardingPolicyProvider, since it's not currently used as a source of policy for components for the profile. BUG=321281 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/policy/profile_policy_connector.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Joao da Silva
Thanks for spotting this! PTAL
7 years, 1 month ago (2013-11-22 17:27:35 UTC) #1
Mattias Nissler (ping if slow)
This looks good, but here's one thing I don't understand. The original CL also dropped ...
7 years, 1 month ago (2013-11-22 18:05:17 UTC) #2
Joao da Silva
The testing provider overrides the platform provider, which is still injected.
7 years ago (2013-11-25 09:01:20 UTC) #3
Mattias Nissler (ping if slow)
On 2013/11/25 09:01:20, Joao da Silva wrote: > The testing provider overrides the platform provider, ...
7 years ago (2013-11-25 09:28:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/83413003/1
7 years ago (2013-11-25 09:31:38 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=192682
7 years ago (2013-11-25 10:05:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/83413003/1
7 years ago (2013-11-25 10:12:37 UTC) #7
commit-bot: I haz the power
7 years ago (2013-11-25 16:22:55 UTC) #8
Message was sent while issue was closed.
Change committed as 237083

Powered by Google App Engine
This is Rietveld 408576698