Source/core/html/forms/DateTimeLocalInputType.cpp - Issue 83413002: Derive the step base for an input element as (now) specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/DateTimeLocalInputType.cpp

Issue 83413002: Derive the step base for an input element as (now) specified. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/calendar-picker/calendar-picker-with-step.html ('K') | « Source/core/html/forms/DateInputType.cpp ('k') | Source/core/html/forms/InputType.h » ('j') | Source/core/html/forms/InputType.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/forms/DateTimeLocalInputType.cpp

diff --git a/Source/core/html/forms/DateTimeLocalInputType.cpp b/Source/core/html/forms/DateTimeLocalInputType.cpp

index ff8b66703e62722d7c32125b39455b6eeab6244b..ea69158a9bbd73c81d357d11e7f8534cc7a837cb 100644

--- a/Source/core/html/forms/DateTimeLocalInputType.cpp

+++ b/Source/core/html/forms/DateTimeLocalInputType.cpp

@@ -86,9 +86,9 @@ StepRange DateTimeLocalInputType::createStepRange(AnyStepHandling anyStepHandlin

{

DEFINE_STATIC_LOCAL(const StepRange::StepDescription, stepDescription, (dateTimeLocalDefaultStep, dateTimeLocalDefaultStepBase, dateTimeLocalStepScaleFactor, StepRange::ScaledStepValueShouldBeInteger));

- const Decimal stepBase = parseToNumber(element().fastGetAttribute(minAttr), 0);

- const Decimal minimum = parseToNumber(element().fastGetAttribute(minAttr), Decimal::fromDouble(DateComponents::minimumDateTime()));

- const Decimal maximum = parseToNumber(element().fastGetAttribute(maxAttr), Decimal::fromDouble(DateComponents::maximumDateTime()));

+ const Decimal stepBase = parseToNumber(element().fastGetAttribute(minAttr), element().fastGetAttribute(valueAttr), 0);

+ const Decimal minimum = parseToNumber(element().fastGetAttribute(minAttr), String(), Decimal::fromDouble(DateComponents::minimumDateTime()));

+ const Decimal maximum = parseToNumber(element().fastGetAttribute(maxAttr), String(), Decimal::fromDouble(DateComponents::maximumDateTime()));

const Decimal step = StepRange::parseStep(anyStepHandling, stepDescription, element().fastGetAttribute(stepAttr));

return StepRange(stepBase, minimum, maximum, step, stepDescription);

}