Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 834113005: Add d8 target to the GN build. (Closed)

Created:
5 years, 11 months ago by brettw
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add d8 target to the GN build. Also formats the rest of the file with "gn format". This accounts for all the changes except for the "d8" target additions. Committed: https://crrev.com/36383f08c1f692ea797d54a27d7c6b3d3d53b440 Cr-Commit-Position: refs/heads/master@{#25984}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -134 lines) Patch
M BUILD.gn View 1 21 chunks +194 lines, -134 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
brettw
5 years, 11 months ago (2015-01-05 08:27:20 UTC) #3
brettw
Hi Michael, Jochen seems to be OOO, can you review this for me? I need ...
5 years, 11 months ago (2015-01-07 02:51:48 UTC) #5
Michael Achenbach
Can't hurt to add Jochen anyways. I don't know much about gn yet.
5 years, 11 months ago (2015-01-07 08:50:48 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-07 13:49:01 UTC) #8
brettw
Can somebody land this for me? (I'm assuming the commit checkbox still doesn't work for ...
5 years, 11 months ago (2015-01-08 02:17:38 UTC) #9
caitp (gmail)
On 2015/01/08 02:17:38, brettw wrote: > Can somebody land this for me? (I'm assuming the ...
5 years, 11 months ago (2015-01-08 02:18:23 UTC) #10
brettw
Yay! It wasn't hooked up last time I tried.
5 years, 11 months ago (2015-01-08 04:48:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/834113005/40001
5 years, 11 months ago (2015-01-08 04:49:08 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-08 05:16:44 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/36383f08c1f692ea797d54a27d7c6b3d3d53b440 Cr-Commit-Position: refs/heads/master@{#25984}
5 years, 11 months ago (2015-01-08 05:16:57 UTC) #15
Yang
On 2015/01/08 05:16:57, I haz the power (commit-bot) wrote: > Patchset 2 (id:??) landed as ...
5 years, 11 months ago (2015-01-08 08:35:15 UTC) #16
Yang
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/838983002/ by yangguo@chromium.org. ...
5 years, 11 months ago (2015-01-08 08:37:14 UTC) #17
Michael Achenbach
5 years, 11 months ago (2015-01-08 12:17:39 UTC) #18
Message was sent while issue was closed.
This was not the reason for the roll block and can be relanded.

Powered by Google App Engine
This is Rietveld 408576698