Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 8341074: Use string literal, not a char[] variable, in UMA_HISTOGRAM_ENUMERATION. (Closed)

Created:
9 years, 1 month ago by palmer
Modified:
9 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Use string literal, not a char[] variable, in UMA_HISTOGRAM_ENUMERATION. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M chrome/renderer/chrome_render_view_observer.cc View 3 chunks +36 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palmer
9 years, 1 month ago (2011-10-27 18:48:08 UTC) #1
Chris Evans
On 2011/10/27 18:48:08, Chris P. wrote: Thanks LGTM
9 years, 1 month ago (2011-10-27 18:50:36 UTC) #2
Chris Evans
On 2011/10/27 18:50:36, Chris Evans wrote: > On 2011/10/27 18:48:08, Chris P. wrote: > > ...
9 years, 1 month ago (2011-10-27 18:56:33 UTC) #3
palmer
9 years, 1 month ago (2011-10-27 19:03:55 UTC) #4
> Actually, it would probably be better to have just one call into UMA_HIST...
at
> the end, iff the preceding logic sets a variable.
> 
> This eliminates a lot of duplication, and potentially code, depending upon the
> macro's implementation.
> 
> Sorry to be a PITA, fancy doing that? Let me know if not, I can do it, it's my
> mess.

Oops, I already committed this CL. I'll roll a new one to do that. I like to
make code smaller. :)

Powered by Google App Engine
This is Rietveld 408576698