Issue 8341014: Age the number string cache so it does not keep strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
9 years, 2 months ago by Erik Corry

Modified:
9 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Age the number string cache so it does not keep strings alive for ever. This is to fix http://code.google.com/p/v8/issues/detail?id=1605

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+196 lines, -95 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	4 chunks	+29 lines, -20 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+10 lines, -1 line	1 comment	Download
M	src/heap.cc	View	4 chunks	+77 lines, -29 lines	1 comment	Download
M	src/ia32/code-stubs-ia32.cc	View	4 chunks	+41 lines, -22 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	4 chunks	+31 lines, -23 lines	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Chromium)

the question here: what is the motivation for making number string cache flushing more complicated? ...

9 years, 2 months ago (2011-10-18 15:30:38 UTC) #2

Vyacheslav Egorov (Chromium)

9 years, 2 months ago (2011-10-18 15:30:43 UTC) #3

the question here: what is the motivation for making number string cache
flushing more complicated?

do we have any benchmark?