Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: chromeos/timezone/timezone_resolver.h

Issue 834073002: ChromeOS: Implement periodic timezone refresh on geolocation data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch feature to disabled by default. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/timezone/timezone_resolver.h
diff --git a/chromeos/timezone/timezone_resolver.h b/chromeos/timezone/timezone_resolver.h
new file mode 100644
index 0000000000000000000000000000000000000000..1bd91ce32bae095020f25735a44af38dcdb92aac
--- /dev/null
+++ b/chromeos/timezone/timezone_resolver.h
@@ -0,0 +1,90 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_TIMEZONE_TIMEZONE_RESOLVER_H_
+#define CHROMEOS_TIMEZONE_TIMEZONE_RESOLVER_H_
+
+#include "base/callback.h"
+#include "base/macros.h"
+#include "base/threading/thread_checker.h"
+#include "chromeos/chromeos_export.h"
+#include "net/url_request/url_request_context_getter.h"
+#include "url/gurl.h"
+
+class PrefRegistrySimple;
+class PrefService;
+
+namespace chromeos {
+
+struct TimeZoneResponseData;
+
+// This class implements periodic timezone synchronization.
+class CHROMEOS_EXPORT TimeZoneResolver {
+ public:
+ class TimeZoneResolverImpl;
+
+ // This callback will be called when new timezone arrives.
+ typedef base::Callback<void(const TimeZoneResponseData*)>
+ ApplyTimeZoneCallback;
stevenjb 2015/01/29 18:29:20 using ApplyTimeZoneCallback = base::Callback<void(
Alexander Alekseev 2015/01/29 19:51:08 Done.
+
+ // chromeos::DelayNetworkCall cannot be used directly due to link
+ // restrictions.
+ typedef base::Callback<void(const base::Closure&)> DelayNetworkCallClosure;
stevenjb 2015/01/29 18:29:20 ditto
Alexander Alekseev 2015/01/29 19:51:08 Done.
+
+ // This is a LocalState preference to store base::Time value of the last
+ // request.
+ // It is used to limit request rate on browser restart.
stevenjb 2015/01/29 18:29:20 Combine lines
Alexander Alekseev 2015/01/29 19:51:08 Done.
+ static const char kLastTimeZoneRefreshTime[];
+
+ TimeZoneResolver(scoped_refptr<net::URLRequestContextGetter> context,
+ const GURL& url,
+ const ApplyTimeZoneCallback& apply_timezone,
+ const DelayNetworkCallClosure& delay_network_call,
+ PrefService* local_state);
+ ~TimeZoneResolver();
+
+ // Starts periodic timezone refresh.
+ void Start();
+
+ // Cancels current request and stops periodic timezone refresh.
+ void Stop();
+
+ // Register prefs to LocalState.
+ static void RegisterPrefs(PrefRegistrySimple* registry);
+
+ scoped_refptr<net::URLRequestContextGetter> context() const {
+ return context_;
+ }
+
+ DelayNetworkCallClosure delay_network_call() const {
+ return delay_network_call_;
+ }
+
+ ApplyTimeZoneCallback apply_timezone() const { return apply_timezone_; }
+
+ PrefService* local_state() const { return local_state_; }
+
+ // Expose internal fuctions for testing.
+ static int MaxRequestsCountForIntervalForTesting(
+ const double interval_seconds);
+ static int IntervalForNextRequestForTesting(const int requests);
+
+ private:
+ scoped_refptr<net::URLRequestContextGetter> context_;
+ const GURL url_;
+
+ const ApplyTimeZoneCallback apply_timezone_;
+ const DelayNetworkCallClosure delay_network_call_;
+ PrefService* local_state_;
+
+ scoped_ptr<TimeZoneResolverImpl> implementation_;
+
+ base::ThreadChecker thread_checker_;
+
+ DISALLOW_COPY_AND_ASSIGN(TimeZoneResolver);
+};
+
+} // namespace chromeos
+
+#endif // CHROMEOS_TIMEZONE_TIMEZONE_RESOLVER_H_

Powered by Google App Engine
This is Rietveld 408576698