content/renderer/battery_status/battery_status_dispatcher_unittest.cc - Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/battery_status/battery_status_dispatcher_unittest.cc

Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixup per review feedback Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/battery_status/battery_status_dispatcher.cc ('k') | device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/battery_status/battery_status_dispatcher_unittest.cc

diff --git a/content/renderer/battery_status/battery_status_dispatcher_unittest.cc b/content/renderer/battery_status/battery_status_dispatcher_unittest.cc

index 94a84bbe9cb59d6879e4739f15fba9f7076ebff4..5f0d2e819e0c5d91af512bd4b3cb911cb239e13a 100644

--- a/content/renderer/battery_status/battery_status_dispatcher_unittest.cc

+++ b/content/renderer/battery_status/battery_status_dispatcher_unittest.cc

@@ -58,6 +58,9 @@ class BatteryStatusDispatcherTest : public testing::Test {

};

TEST_F(BatteryStatusDispatcherTest, UpdateListener) {

+ // TODO(darin): This test isn't super interesting. It just exercises

+ // conversion b/w device::BatteryStatus and blink::WebBatteryStatus.

device::BatteryStatus status;

status.charging = true;

status.charging_time = 100;