content/renderer/battery_status/battery_status_dispatcher.h - Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/battery_status/battery_status_dispatcher.h

Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixup per review feedback Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/battery_status/battery_monitor_integration_browsertest.cc ('k') | content/renderer/battery_status/battery_status_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/battery_status/battery_status_dispatcher.h

diff --git a/content/renderer/battery_status/battery_status_dispatcher.h b/content/renderer/battery_status/battery_status_dispatcher.h

index 23f3673dbc5f8fb8ba69fe3de6a87e6a0c3a4c3f..f117a4b385e7ade0d39565f84bdb9bf6b9334a3c 100644

--- a/content/renderer/battery_status/battery_status_dispatcher.h

+++ b/content/renderer/battery_status/battery_status_dispatcher.h

@@ -16,17 +16,16 @@ class WebBatteryStatusListener;

namespace content {

-class CONTENT_EXPORT BatteryStatusDispatcher

- : public NON_EXPORTED_BASE(device::BatteryStatusObserver) {

+class CONTENT_EXPORT BatteryStatusDispatcher {

public:

explicit BatteryStatusDispatcher(blink::WebBatteryStatusListener* listener);

- ~BatteryStatusDispatcher() override;

+ ~BatteryStatusDispatcher();

private:

friend class BatteryStatusDispatcherTest;

- // BatteryStatusObserver method.

- void DidChange(device::BatteryStatusPtr battery_status) override;

+ void QueryNextStatus();

+ void DidChange(device::BatteryStatusPtr battery_status);

device::BatteryMonitorPtr monitor_;

blink::WebBatteryStatusListener* listener_;