Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: device/battery/battery_monitor_impl.cc

Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixup per review feedback Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/battery/battery_monitor_impl.h ('k') | device/battery/battery_status_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/battery/battery_monitor_impl.h" 5 #include "device/battery/battery_monitor_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 8
9 namespace device { 9 namespace device {
10 10
11 // static 11 // static
12 void BatteryMonitorImpl::Create( 12 void BatteryMonitorImpl::Create(
13 mojo::InterfaceRequest<BatteryMonitor> request) { 13 mojo::InterfaceRequest<BatteryMonitor> request) {
14 new BatteryMonitorImpl(request.Pass()); 14 new BatteryMonitorImpl(request.Pass());
15 } 15 }
16 16
17 BatteryMonitorImpl::BatteryMonitorImpl( 17 BatteryMonitorImpl::BatteryMonitorImpl(
18 mojo::InterfaceRequest<BatteryMonitor> request) 18 mojo::InterfaceRequest<BatteryMonitor> request)
19 : binding_(this, request.Pass()), 19 : binding_(this, request.Pass()),
20 subscription_(BatteryStatusService::GetInstance()->AddCallback( 20 status_to_report_(false) {
21 base::Bind(&BatteryMonitorImpl::DidChange, base::Unretained(this)))) { 21 // NOTE: DidChange may be called before AddCallback returns. This is done to
22 // report current status.
23 subscription_ = BatteryStatusService::GetInstance()->AddCallback(
24 base::Bind(&BatteryMonitorImpl::DidChange, base::Unretained(this)));
22 } 25 }
23 26
24 BatteryMonitorImpl::~BatteryMonitorImpl() { 27 BatteryMonitorImpl::~BatteryMonitorImpl() {
25 } 28 }
26 29
30 void BatteryMonitorImpl::QueryNextStatus(
31 const BatteryStatusCallback& callback) {
32 callbacks_.push_back(callback);
33
34 if (status_to_report_)
35 ReportStatus();
36 }
37
27 void BatteryMonitorImpl::RegisterSubscription() { 38 void BatteryMonitorImpl::RegisterSubscription() {
28 } 39 }
29 40
30 void BatteryMonitorImpl::DidChange(const BatteryStatus& battery_status) { 41 void BatteryMonitorImpl::DidChange(const BatteryStatus& battery_status) {
31 BatteryStatusPtr status(BatteryStatus::New()); 42 status_ = battery_status;
32 *status = battery_status; 43 status_to_report_ = true;
33 binding_.client()->DidChange(status.Pass()); 44
45 if (!callbacks_.empty())
46 ReportStatus();
47 }
48
49 void BatteryMonitorImpl::ReportStatus() {
50 for (const auto& callback : callbacks_)
51 callback.Run(status_.Clone());
52 callbacks_.clear();
53
54 status_to_report_ = false;
34 } 55 }
35 56
36 } // namespace device 57 } // namespace device
OLDNEW
« no previous file with comments | « device/battery/battery_monitor_impl.h ('k') | device/battery/battery_status_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698