Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: device/battery/battery_monitor_impl.h

Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_BATTERY_BATTERY_MONITOR_IMPL_H_ 5 #ifndef DEVICE_BATTERY_BATTERY_MONITOR_IMPL_H_
6 #define DEVICE_BATTERY_BATTERY_MONITOR_IMPL_H_ 6 #define DEVICE_BATTERY_BATTERY_MONITOR_IMPL_H_
7 7
8 #include <deque>
9
8 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
9 #include "device/battery/battery_export.h" 11 #include "device/battery/battery_export.h"
10 #include "device/battery/battery_monitor.mojom.h" 12 #include "device/battery/battery_monitor.mojom.h"
11 #include "device/battery/battery_status_service.h" 13 #include "device/battery/battery_status_service.h"
12 #include "mojo/public/cpp/bindings/strong_binding.h" 14 #include "mojo/public/cpp/bindings/strong_binding.h"
13 15
14 namespace device { 16 namespace device {
15 17
16 class BatteryMonitorImpl : public BatteryMonitor { 18 class BatteryMonitorImpl : public BatteryMonitor {
17 public: 19 public:
18 DEVICE_BATTERY_EXPORT static void Create( 20 DEVICE_BATTERY_EXPORT static void Create(
19 mojo::InterfaceRequest<BatteryMonitor> request); 21 mojo::InterfaceRequest<BatteryMonitor> request);
20 22
21 private: 23 private:
24 typedef mojo::Callback<void(BatteryStatusPtr)> BatteryStatusCallback;
25
22 explicit BatteryMonitorImpl(mojo::InterfaceRequest<BatteryMonitor> request); 26 explicit BatteryMonitorImpl(mojo::InterfaceRequest<BatteryMonitor> request);
23 ~BatteryMonitorImpl() override; 27 ~BatteryMonitorImpl() override;
24 28
29 // BatteryMonitor methods:
30 void QueryNextStatus(const BatteryStatusCallback& callback) override;
31
25 void RegisterSubscription(); 32 void RegisterSubscription();
26 void DidChange(const BatteryStatus& battery_status); 33 void DidChange(const BatteryStatus& battery_status);
34 void ReportStatus();
27 35
28 mojo::StrongBinding<BatteryMonitor> binding_; 36 mojo::StrongBinding<BatteryMonitor> binding_;
29 scoped_ptr<BatteryStatusService::BatteryUpdateSubscription> subscription_; 37 scoped_ptr<BatteryStatusService::BatteryUpdateSubscription> subscription_;
38 std::deque<BatteryStatusCallback> callbacks_;
timvolodine 2015/01/07 14:38:51 nit: std::vector is probably sufficient here?
39 BatteryStatus status_;
40 bool status_to_report_;
30 41
31 DISALLOW_COPY_AND_ASSIGN(BatteryMonitorImpl); 42 DISALLOW_COPY_AND_ASSIGN(BatteryMonitorImpl);
32 }; 43 };
33 44
34 } // namespace device 45 } // namespace device
35 46
36 #endif // DEVICE_BATTERY_BATTERY_MONITOR_IMPL_H_ 47 #endif // DEVICE_BATTERY_BATTERY_MONITOR_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698