device/battery/battery_monitor.mojom - Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/battery/battery_monitor.mojom

Issue 833983002: Stop using [Client=...] feature of Mojom for BatteryMonitor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorImpl.java ('K') | « device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorImpl.java ('k') | device/battery/battery_monitor_impl.h » ('j') | device/battery/battery_monitor_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module device;	5 module device;

6	6

7 import "device/battery/battery_status.mojom";	7 import "device/battery/battery_status.mojom";

8	8

9 // A BatteryMonitor will periodically call its client's DidChange method.

10 [Client=BatteryStatusObserver]
timvolodine 2015/01/07 14:38:51 does this mean the [Client=..] feature is deprecat does this mean the [Client=..] feature is deprecated and should not be used anymore? the idea seemed kind of nice and resulted in simpler monitor implementation. I understand the new design is because we care about producer/consumer synchronization. If this is a general concern maybe there is a way to have a mojo client primitive which would not queue and transmit only the last data (similar to what we have with shared memory).
11 interface BatteryMonitor {	9 interface BatteryMonitor {

	10 // Battery status is reported once it changes or immediately if this is the

	11 // first call to QueryNextStatus on this instance. QueryNextStatus calls may

	12 // be throttled by the service. Overlapping calls to QueryNextStatus are

	13 // supported.
	timvolodine 2015/01/07 14:38:51 description for this patch talks about an anti-pat description for this patch talks about an anti-pattern issue - is there any bug associated with this? if so maybe add it to description. ppi 2015/01/07 19:37:36 Did you mean s/supported/not supported/? Did you mean s/supported/not supported/? ppi 2015/01/07 19:41:12 Ach, you probably did mean "supported", please dis Ach, you probably did mean "supported", please disregard. darin (slow to review) 2015/01/07 20:39:52 Yup, this is what the queuing of callbacks is all Show quoted text On 2015/01/07 19:41:12, ppi wrote: > Ach, you probably did mean "supported", please disregard. Yup, this is what the queuing of callbacks is all about in the implementation.
	14 QueryNextStatus() => (BatteryStatus status);
	qsr 2015/01/07 09:05:00 Any reason you choose this design, instead of havi Any reason you choose this design, instead of having something like: StartObserving(BatteryStatusObserver observer); The reason I asked is because this doubled the number of message for this API => Until now, the monitor was sending all updates, now the client must call this method back each time it reveives an update.
12 };	15 };

13

14 interface BatteryStatusObserver {

15 DidChange(BatteryStatus status);

16 };

OLD	NEW