Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 833923003: Revert of Fix EnableTerminationOnOutOfMemory for malloc (Closed)

Created:
5 years, 11 months ago by Marijn Kruisselbrink
Modified:
5 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix EnableTerminationOnOutOfMemory for malloc (patchset #1 id:1 of https://codereview.chromium.org/836733006/) Reason for revert: Fails to compile on win8 gn dbg builder (http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/2649/steps/compile/logs/stdio): c:\b\build\slave\win8_gn__dbg_\build\src\base\process\memory_win.cc(22) :error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win8_gn__dbg_\build\src\base\process\memory_win.cc(22) : warning C4702: unreachable code Original issue's description: > Fix EnableTerminationOnOutOfMemory for malloc > > Currently only crashes on new and new[]. With the change it will also > crash when there is no memory for malloc as well. > > BUG=434397 > TEST=none. > > Committed: https://crrev.com/22d64abdc792516fd0f4895b26ae3a73c85239e0 > Cr-Commit-Position: refs/heads/master@{#310320} TBR=grt@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=434397 Committed: https://crrev.com/148a2913a8300f6d54aebb399d3190a36b826808 Cr-Commit-Position: refs/heads/master@{#310323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M base/process/memory_win.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marijn Kruisselbrink
Created Revert of Fix EnableTerminationOnOutOfMemory for malloc
5 years, 11 months ago (2015-01-07 18:29:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833923003/1
5 years, 11 months ago (2015-01-07 18:30:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 18:31:36 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 18:32:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/148a2913a8300f6d54aebb399d3190a36b826808
Cr-Commit-Position: refs/heads/master@{#310323}

Powered by Google App Engine
This is Rietveld 408576698