Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 833913002: Cast the scratch resource key in order to fix a warning (Closed)

Created:
5 years, 11 months ago by Kimmo Kinnunen
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Cast the scratch resource key in order to fix a warning Cast the generated scratch resource key to GrScratchKey::ResourceType. The key is generated with atomic ops that operate on int32_t, while the resource type is unsigned. Fixes a compile-breaking warning with gcc (Ubuntu/Linaro 4.6.4-1ubuntu1~12.04) 4.6.4.

Patch Set 1 #

Patch Set 2 : address review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/gpu/GrResourceCache2.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Kimmo Kinnunen
5 years, 11 months ago (2015-01-02 06:52:50 UTC) #2
robertphillips
Prior to https://codereview.chromium.org/815833004/ (Add a simpler key type for scratch resource keys), ResourceType was a ...
5 years, 11 months ago (2015-01-02 21:27:54 UTC) #3
Kimmo Kinnunen
On 2015/01/02 21:27:54, robertphillips wrote: > Prior to https://codereview.chromium.org/815833004/ (Add a simpler key type for ...
5 years, 11 months ago (2015-01-05 08:56:26 UTC) #4
robertphillips
Does https://codereview.chromium.org/827923006/ (Cap id size returned by GrScratchKey::GenerateResourceType) fix the compiler warning for you?
5 years, 11 months ago (2015-01-05 20:35:58 UTC) #5
Kimmo Kinnunen
5 years, 11 months ago (2015-01-07 07:23:37 UTC) #6
On 2015/01/05 20:35:58, robertphillips wrote:
> Does https://codereview.chromium.org/827923006/ (Cap id size returned by
> GrScratchKey::GenerateResourceType) fix the compiler warning for you?

Works

Powered by Google App Engine
This is Rietveld 408576698