chrome/browser/ui/views/web_dialog_view_browsertest.cc - Issue 833893004: [MacViews] Disable WebDialogBrowserTest.SizeWindow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/web_dialog_view_browsertest.cc

Issue 833893004: [MacViews] Disable WebDialogBrowserTest.SizeWindow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/web_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/web_dialog_view_browsertest.cc b/chrome/browser/ui/views/web_dialog_view_browsertest.cc

index 2e8c17ef370175b466bbc631e5150abad0583813..d5ec5bded416237500a10b010c5a6a23504c725e 100644

--- a/chrome/browser/ui/views/web_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/web_dialog_view_browsertest.cc

@@ -86,7 +86,9 @@ class WebDialogBrowserTest : public InProcessBrowserTest {

// Windows has some issues resizing windows. An off by one problem, and a

// minimum size that seems too big. See http://crbug.com/52602.

-#if defined(OS_WIN)

+// On Mac with toolkit_views, this test compiles but crashes at

+// CreateWindowWithParent. See http://crbug.com/404979.

tapted 2015/01/08 05:33:38 made a better bug for this outlining the issue: 44

jackhou1 2015/01/08 06:36:04 Done.

+#if defined(OS_WIN) || defined(OS_MACOSX)

#define MAYBE_SizeWindow DISABLED_SizeWindow

#else

#define MAYBE_SizeWindow SizeWindow

« no previous file with comments | « no previous file | no next file » | no next file with comments »