[MacViews] Disable WebDialogBrowserTest.SizeWindow.

[MacViews] Disable WebDialogBrowserTest.SizeWindow.

The test crashes on Mac because it tries to create a views::Widget with
a WebContents view as parent, but the WebContents are still Cocoa based.

Disable the test for now since we don't yet use the Views WebDialog on
Mac. Once we eventually do, the above problem will be resolved.

BUG=404979, 447086
Committed: https://crrev.com/00150db7931eae15d7080d2da1e8620fe4f4037b
Cr-Commit-Position: refs/heads/master@{#310648}

[jackhou1, 2015-01-08 04:24:21]

jackhou@chromium.org changed reviewers:
+ tapted@chromium.org

[jackhou1, 2015-01-08 04:24:22]

I figured it's better to disable it because it still gets compiled. Do you
prefer a gyp-exclude?

[tapted, 2015-01-08 05:33:38]

yep sounds good. lgtm with the below

https://codereview.chromium.org/833893004/diff/1/chrome/browser/ui/views/web_...
File chrome/browser/ui/views/web_dialog_view_browsertest.cc (right):

https://codereview.chromium.org/833893004/diff/1/chrome/browser/ui/views/web_...
chrome/browser/ui/views/web_dialog_view_browsertest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
CL description
> Mac. One we eventually do, the above problem will be resolved.

One -> Once

https://codereview.chromium.org/833893004/diff/1/chrome/browser/ui/views/web_...
chrome/browser/ui/views/web_dialog_view_browsertest.cc:90: //
CreateWindowWithParent. See http://crbug.com/404979.
made a better bug for this outlining the issue: 447086 . But I'd keep both in
the CL description.

[jackhou1, 2015-01-08 06:36:04]

https://codereview.chromium.org/833893004/diff/1/chrome/browser/ui/views/web_...
File chrome/browser/ui/views/web_dialog_view_browsertest.cc (right):

https://codereview.chromium.org/833893004/diff/1/chrome/browser/ui/views/web_...
chrome/browser/ui/views/web_dialog_view_browsertest.cc:1: // Copyright (c) 2012
The Chromium Authors. All rights reserved.
On 2015/01/08 05:33:38, tapted wrote:
> CL description
> > Mac. One we eventually do, the above problem will be resolved.
> 
> One -> Once

Done.

https://codereview.chromium.org/833893004/diff/1/chrome/browser/ui/views/web_...
chrome/browser/ui/views/web_dialog_view_browsertest.cc:90: //
CreateWindowWithParent. See http://crbug.com/404979.
On 2015/01/08 05:33:38, tapted wrote:
> made a better bug for this outlining the issue: 447086 . But I'd keep both in
> the CL description.

Done.

[jackhou1, 2015-01-08 06:36:48]

jackhou@chromium.org changed reviewers:
+ sky@chromium.org

[jackhou1, 2015-01-08 06:36:48]

sky, please review for OWNERS

[sky, 2015-01-08 22:39:21]

LGTM

[sky, 2015-01-08 22:40:02]

Also, make sure you file a bug so that you remember to reenable the test when
everything is sorted out.

[jackhou1, 2015-01-09 00:09:11]

On 2015/01/08 22:40:02, sky wrote:
> Also, make sure you file a bug so that you remember to reenable the test when
> everything is sorted out.

Added a reference to this CL from http://crbug.com/447086.

[jackhou1, 2015-01-09 00:09:15]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2015-01-09 00:10:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/833893004/20001

[commit-bot: I haz the power, 2015-01-09 01:05:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-09 01:06:31]

Patchset 2 (id:??) landed as
https://crrev.com/00150db7931eae15d7080d2da1e8620fe4f4037b
Cr-Commit-Position: refs/heads/master@{#310648}