Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 833893003: Move UserActivityDetector to ui/base/user_activity/. (Closed)

Created:
5 years, 11 months ago by Daniel Erat
Modified:
5 years, 11 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tdresser+watch_chromium.org, jdduke+watch_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move UserActivityDetector to ui/base/user_activity/. Move UserActivityDetector and UserActivityObserver out of ui/wm/core/ so that other classes in ui/base/ can depend on them. This is needed in order to be able to later move chrome/browser/idle_chromeos.cc out of chrome/ so that the chrome.idle API can eventually be moved to extensions/. BUG=446320 Committed: https://crrev.com/2d4e62d2cbd43d83fc43d58f0fdaa904633c33c1 Cr-Commit-Position: refs/heads/master@{#310773}

Patch Set 1 #

Patch Set 2 : use ui/base/user_activity/ instead #

Patch Set 3 : fix app_shell #

Patch Set 4 : fix non-chromeos app_shell compilation. did not know this was a thing. #

Patch Set 5 : update for gn :-/ #

Patch Set 6 : merge #

Patch Set 7 : don't build test on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -577 lines) Patch
M ash/display/display_change_observer_chromeos.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell.h View 4 chunks +2 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M athena/env/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M athena/env/athena_env_impl.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/idle_detector.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/idle_detector.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/session_length_limiter.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/session_length_limiter.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/idle_chromeos.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M ui/base/BUILD.gn View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M ui/base/ui_base.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
A + ui/base/user_activity/user_activity_detector.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + ui/base/user_activity/user_activity_detector.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/base/user_activity/user_activity_detector_unittest.cc View 1 3 chunks +10 lines, -16 lines 0 comments Download
A + ui/base/user_activity/user_activity_observer.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
M ui/chromeos/user_activity_power_manager_notifier.h View 1 1 chunk +6 lines, -9 lines 0 comments Download
M ui/chromeos/user_activity_power_manager_notifier.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
D ui/wm/core/user_activity_detector.h View 1 chunk +0 lines, -84 lines 0 comments Download
D ui/wm/core/user_activity_detector.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D ui/wm/core/user_activity_detector_unittest.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D ui/wm/core/user_activity_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
M ui/wm/wm.gyp View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
Daniel Erat
oshima: please look at athena. scott: please look at everything else!
5 years, 11 months ago (2015-01-08 02:51:02 UTC) #2
sky
I tend to think of ui/events as more about event processing and event structures and ...
5 years, 11 months ago (2015-01-08 03:31:44 UTC) #3
sadrul
On 2015/01/08 03:31:44, sky wrote: > I tend to think of ui/events as more about ...
5 years, 11 months ago (2015-01-08 04:16:09 UTC) #4
oshima
On 2015/01/08 04:16:09, sadrul (OOO) wrote: > On 2015/01/08 03:31:44, sky wrote: > > I ...
5 years, 11 months ago (2015-01-08 09:02:46 UTC) #5
Daniel Erat
okay, all thoughts that i had. thanks! :-) i'll go with ui/user_activity/; i didn't know ...
5 years, 11 months ago (2015-01-08 14:19:44 UTC) #6
Daniel Erat
started switching to ui/user_activity, but creating a new unit test target for such a tiny ...
5 years, 11 months ago (2015-01-08 15:16:57 UTC) #7
Daniel Erat
another look? after some discussion with scott, i went with ui/base/user_activity.
5 years, 11 months ago (2015-01-08 21:23:57 UTC) #8
oshima
athena lgtm. you may tbr athena from now on as we'll soon remove it from ...
5 years, 11 months ago (2015-01-08 21:31:23 UTC) #9
sky
LGTM - thanks
5 years, 11 months ago (2015-01-08 23:40:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833893003/90001
5 years, 11 months ago (2015-01-08 23:49:24 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/35986)
5 years, 11 months ago (2015-01-09 00:38:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833893003/110001
5 years, 11 months ago (2015-01-09 15:16:10 UTC) #16
commit-bot: I haz the power
Committed patchset #7 (id:110001)
5 years, 11 months ago (2015-01-09 16:09:47 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 16:11:08 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/2d4e62d2cbd43d83fc43d58f0fdaa904633c33c1
Cr-Commit-Position: refs/heads/master@{#310773}

Powered by Google App Engine
This is Rietveld 408576698