Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 83383007: Adding SkDeferredCanvas::NoticifationClient to the exported API. (Closed)

Created:
7 years, 1 month ago by Stephen Chennney
Modified:
7 years ago
Reviewers:
reed, bsalomon, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Adding SkDeferredCanvas::NoticifationClient to the exported API. R=reed,robertphillips BUG=1861 Committed: http://code.google.com/p/skia/source/detail?r=12380

Patch Set 1 #

Patch Set 2 : Second attempt #

Patch Set 3 : Also need SkBitmap::Allocatorw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkBitmap.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen Chennney
This is blocking a Blink change. It would be truly amazing if we could get ...
7 years, 1 month ago (2013-11-22 23:20:46 UTC) #1
bsalomon
On 2013/11/22 23:20:46, Stephen Chenney wrote: > This is blocking a Blink change. It would ...
7 years ago (2013-11-25 14:21:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/schenney@chromium.org/83383007/50001
7 years ago (2013-11-25 14:46:16 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Mac10.7-Clang-x86-Release-Trybot for step(s) BuildTests http://skiabot-master.pogerlabs.com:10117/buildstatus?builder=Build-Mac10.7-Clang-x86-Release-Trybot&number=1058
7 years ago (2013-11-25 15:04:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/schenney@chromium.org/83383007/50001
7 years ago (2013-11-25 15:38:10 UTC) #5
commit-bot: I haz the power
7 years ago (2013-11-25 15:44:39 UTC) #6
Message was sent while issue was closed.
Change committed as 12380

Powered by Google App Engine
This is Rietveld 408576698