Source/core/inspector/InjectedScript.h - Issue 83383002: DevTools: Allow setting -0 value to object property

Unified Diff: Source/core/inspector/InjectedScript.h

Issue 83383002: DevTools: Allow setting -0 value to object property (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/runtime/runtime-setPropertyValue-expected.txt ('k') | Source/core/inspector/InjectedScript.cpp » ('j') | Source/devtools/protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InjectedScript.h

diff --git a/Source/core/inspector/InjectedScript.h b/Source/core/inspector/InjectedScript.h

index 05cfcf320fb4b7d39dbe18095f098e5d26973b11..5397705c5f1bb49a491c2e51d069d0aa8452f3da 100644

--- a/Source/core/inspector/InjectedScript.h

+++ b/Source/core/inspector/InjectedScript.h

@@ -50,32 +50,9 @@ public:

InjectedScript();

~InjectedScript() { }

- void evaluate(ErrorString*,

- const String& expression,

- const String& objectGroup,

- bool includeCommandLineAPI,

- bool returnByValue,

- bool generatePreview,

- RefPtr<TypeBuilder::Runtime::RemoteObject>* result,

- TypeBuilder::OptOutput<bool>* wasThrown);

- void callFunctionOn(ErrorString*,

- const String& objectId,

- const String& expression,

- const String& arguments,

- bool returnByValue,

- bool generatePreview,

- RefPtr<TypeBuilder::Runtime::RemoteObject>* result,

- TypeBuilder::OptOutput<bool>* wasThrown);

- void evaluateOnCallFrame(ErrorString*,

- const ScriptValue& callFrames,

- const String& callFrameId,

- const String& expression,

- const String& objectGroup,

- bool includeCommandLineAPI,

- bool returnByValue,

- bool generatePreview,

- RefPtr<TypeBuilder::Runtime::RemoteObject>* result,

- TypeBuilder::OptOutput<bool>* wasThrown);

+ void evaluate(ErrorString*, const String& expression, const String& objectGroup, bool includeCommandLineAPI, bool returnByValue, bool forceObjectId, bool generatePreview, RefPtr<TypeBuilder::Runtime::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown);

+ void callFunctionOn(ErrorString*, const String& objectId, const String& expression, const String& arguments, bool returnByValue, bool forceObjectId, bool generatePreview, RefPtr<TypeBuilder::Runtime::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown);

+ void evaluateOnCallFrame(ErrorString*, const ScriptValue& callFrames, const String& callFrameId, const String& expression, const String& objectGroup, bool includeCommandLineAPI, bool returnByValue, bool forceObjectId, bool generatePreview, RefPtr<TypeBuilder::Runtime::RemoteObject>* result, TypeBuilder::OptOutput<bool>* wasThrown);

void restartFrame(ErrorString*, const ScriptValue& callFrames, const String& callFrameId, RefPtr<JSONObject>* result);

void getStepInPositions(ErrorString*, const ScriptValue& callFrames, const String& callFrameId, RefPtr<TypeBuilder::Array<TypeBuilder::Debugger::Location> >& positions);

void setVariableValue(ErrorString*, const ScriptValue& callFrames, const String* callFrameIdOpt, const String* functionObjectIdOpt, int scopeNumber, const String& variableName, const String& newValueStr);