Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 83383002: DevTools: Allow setting -0 value to object property (Closed)

Created:
7 years, 1 month ago by aandrey
Modified:
7 years ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Allow setting -0 value to object property BUG=321560 R=pfeldman, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162991

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : simplified #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M LayoutTests/inspector/runtime/runtime-setPropertyValue.html View 2 chunks +16 lines, -0 lines 0 comments Download
M LayoutTests/inspector/runtime/runtime-setPropertyValue-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/RemoteObject.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aandrey
7 years, 1 month ago (2013-11-22 12:34:50 UTC) #1
pfeldman
https://codereview.chromium.org/83383002/diff/40001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/83383002/diff/40001/Source/devtools/protocol.json#newcode3178 Source/devtools/protocol.json:3178: { "name": "forceObjectId", "type": "boolean", "optional": true, "hidden": true, ...
7 years, 1 month ago (2013-11-23 15:58:13 UTC) #2
aandrey
Simplified the patch. PTAL.
7 years ago (2013-11-26 16:19:57 UTC) #3
pfeldman
7 years ago (2013-12-02 12:10:06 UTC) #4
pfeldman
lgtm
7 years ago (2013-12-02 12:10:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/83383002/110001
7 years ago (2013-12-02 13:36:30 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-02 15:01:02 UTC) #7
Message was sent while issue was closed.
Change committed as 162991

Powered by Google App Engine
This is Rietveld 408576698