Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1091)

Unified Diff: remoting/host/chromeos/mouse_cursor_monitor_aura.cc

Issue 833693002: Hide the cursor on the client when it is hidden on the host (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/chromeos/mouse_cursor_monitor_aura.cc
diff --git a/remoting/host/chromeos/mouse_cursor_monitor_aura.cc b/remoting/host/chromeos/mouse_cursor_monitor_aura.cc
index ad48f141bc0cc040193096016d546607ba7618c3..03d71ea6d5a5d988792ac8f87ef484dc37017032 100644
--- a/remoting/host/chromeos/mouse_cursor_monitor_aura.cc
+++ b/remoting/host/chromeos/mouse_cursor_monitor_aura.cc
@@ -53,6 +53,11 @@ void MouseCursorMonitorAura::Capture() {
void MouseCursorMonitorAura::NotifyCursorChanged(const ui::Cursor& cursor) {
scoped_ptr<SkBitmap> cursor_bitmap(new SkBitmap());
gfx::Point cursor_hotspot;
+
+ if (cursor.native_type() == ui::kCursorNone) {
+ return;
Sergey Ulanov 2015/01/05 18:00:25 Should we notify the client that the cursor is hid
Wez 2015/01/05 20:02:46 Yes, please do. There is even an EmptyCursorShape(
kelvinp 2015/01/06 02:22:18 Whoa, excellent point. I have taken the step a lit
+ }
+
if (!ui::GetCursorBitmap(cursor, cursor_bitmap.get(), &cursor_hotspot)) {
LOG(ERROR) << "Failed to load bitmap for cursor type:"
<< cursor.native_type();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698