Hide the cursor on the client when it is hidden on the host

remoting/host/video_scheduler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/video_scheduler.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 103 matching lines @@
   // Do nothing if the scheduler is being stopped.
   if (!capturer_)
     return;
 
   scoped_ptr<protocol::CursorShapeInfo> cursor_proto(
       new protocol::CursorShapeInfo());
   cursor_proto->set_width(cursor->image()->size().width());
   cursor_proto->set_height(cursor->image()->size().height());
   cursor_proto->set_hotspot_x(cursor->hotspot().x());
   cursor_proto->set_hotspot_y(cursor->hotspot().y());
+  cursor_proto->set_data(std::string());

[kelvinp, 2015/01/06 02:22:18]

Always initializes with empty data.  Or else
ClientControlDispatcher::CursorShapeIsValid on the host will complains that the
cursor info is missing a required field.  

[Sergey Ulanov, 2015/01/06 18:52:10]

nit: add an empty line above this one and remove it below - that would make it
clear that the block below sets the data field.

[kelvinp, 2015/01/06 22:04:14]

Done.

 
-  std::string data;
   uint8_t* current_row = cursor->image()->data();
   for (int y = 0; y < cursor->image()->size().height(); ++y) {
     cursor_proto->mutable_data()->append(
         current_row,
         current_row + cursor->image()->size().width() *
             webrtc::DesktopFrame::kBytesPerPixel);
     current_row += cursor->image()->stride();
   }
 
   network_task_runner_->PostTask(
@@ skipping 262 matching lines @@
   frame.reset();
 
   scheduler_.RecordEncodeTime(
       base::TimeDelta::FromMilliseconds(packet->encode_time_ms()));
   network_task_runner_->PostTask(
       FROM_HERE, base::Bind(&VideoScheduler::SendVideoPacket, this,
                             base::Passed(&packet)));
 }
 
 }  // namespace remoting