Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: include/v8.h

Issue 83363003: Deprecate old versions of Isolate::SetData and GetData (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 51b226236e7c6f167c92bc3f61d313c869c5973e..6e1ac3f5d1e828b0104cafff000e035964887e89 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4054,11 +4054,9 @@ class V8_EXPORT Isolate {
*/
void Dispose();
- /**
- * Associate embedder-specific data with the isolate. This legacy method
- * puts the data in the 0th slot. It will be deprecated soon.
- */
- V8_INLINE void SetData(void* data);
+ V8_DEPRECATED("Use SetData(0, data) instead.",
+ V8_INLINE void SetData(void* data));
+ V8_DEPRECATED("Use GetData(0) instead.", V8_INLINE void* GetData());
/**
* Associate embedder-specific data with the isolate. |slot| has to be
@@ -4067,13 +4065,6 @@ class V8_EXPORT Isolate {
V8_INLINE void SetData(uint32_t slot, void* data);
/**
- * Retrieve embedder-specific data from the isolate. This legacy method
- * retrieves the data from slot 0. It will be deprecated soon.
- * Returns NULL if SetData has never been called.
- */
- V8_INLINE void* GetData();
-
- /**
* Retrieve embedder-specific data from the isolate.
* Returns NULL if SetData has never been called for the given |slot|.
*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698