Issue 83353002: Exclude benchmark tests from presubmit check in a non-git checkout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83353002: Exclude benchmark tests from presubmit check in a non-git checkout. (Closed)

Created:
7 years, 1 month ago by Yang

Modified:
7 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Exclude benchmark tests from presubmit check in a non-git checkout. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18006

Patch Set 2 : addressed comment #

Patch Set 3 : addressed comment #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	tools/presubmit.py	View	1	2 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nit. https://codereview.chromium.org/83353002/diff/1/tools/presubmit.py File tools/presubmit.py (right): https://codereview.chromium.org/83353002/diff/1/tools/presubmit.py#newcode195 tools/presubmit.py:195: name == 'data' or shorter: name ...

7 years, 1 month ago (2013-11-22 12:18:23 UTC) #2

Yang

7 years, 1 month ago (2013-11-22 12:21:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r18006 (presubmit successful).