Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 833483002: Adds API for testing aria-controls/flowto/owns properties. (Closed)

Created:
5 years, 11 months ago by k.czech
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds API for testing aria-controls/flowto/owns properties. BUG=none Committed: https://crrev.com/510b04c64ef9757b42e7dcf93a7098b313c6a0f2 Cr-Commit-Position: refs/heads/master@{#310271}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixing indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M content/shell/renderer/test_runner/web_ax_object_proxy.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 2 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
k.czech
5 years, 11 months ago (2014-12-29 14:58:48 UTC) #2
dmazzoni
lgtm Please just fix the indentation before landing https://codereview.chromium.org/833483002/diff/1/content/shell/renderer/test_runner/web_ax_object_proxy.cc File content/shell/renderer/test_runner/web_ax_object_proxy.cc (right): https://codereview.chromium.org/833483002/diff/1/content/shell/renderer/test_runner/web_ax_object_proxy.cc#newcode831 content/shell/renderer/test_runner/web_ax_object_proxy.cc:831: return ...
5 years, 11 months ago (2015-01-05 09:12:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833483002/20001
5 years, 11 months ago (2015-01-07 12:03:00 UTC) #5
k.czech
On 2015/01/05 09:12:54, dmazzoni wrote: > lgtm > > Please just fix the indentation before ...
5 years, 11 months ago (2015-01-07 12:10:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 12:44:58 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 12:45:54 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/510b04c64ef9757b42e7dcf93a7098b313c6a0f2
Cr-Commit-Position: refs/heads/master@{#310271}

Powered by Google App Engine
This is Rietveld 408576698