Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 833443003: Remove applyAuthorStyles flag. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove applyAuthorStyles flag. This flag doesn't really make sense in sky, rules should only match if they're from the same scope or are a :host rule in the ShadowRoot on the element. Removing this also eliminates the ScopeContainsLastMatchedElement flag. For now we just check if the scope is null for the same behavior, in the future we'll never let scope be null and we'll just enforce the normal style scoping rules. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/94a1d6f02b24f21a3a94557681d8b40ad37411e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -53 lines) Patch
M sky/engine/core/css/ElementRuleCollector.cpp View 2 chunks +5 lines, -21 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/css/SelectorChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/MatchRequest.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 4 chunks +3 lines, -11 lines 0 comments Download
M sky/engine/core/dom/SelectorQuery.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/TreeScope.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/TreeScope.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
5 years, 11 months ago (2015-01-07 19:27:12 UTC) #1
ojan
lgtm
5 years, 11 months ago (2015-01-07 19:32:34 UTC) #3
esprehn
5 years, 11 months ago (2015-01-07 19:35:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
94a1d6f02b24f21a3a94557681d8b40ad37411e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698