Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: chrome/browser/ui/views/frame/browser_view_layout.cc

Issue 83343006: Enable immersive fullscreen for hosted apps part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_layout.cc b/chrome/browser/ui/views/frame/browser_view_layout.cc
index e346939d6fc4d0abc55dcb5b8e12a1be15d3d568..bb05f6e583031e202df23863c3bf494b63e5304a 100644
--- a/chrome/browser/ui/views/frame/browser_view_layout.cc
+++ b/chrome/browser/ui/views/frame/browser_view_layout.cc
@@ -204,7 +204,8 @@ gfx::Size BrowserViewLayout::GetMinimumSize() {
gfx::Size contents_size(contents_split_->GetMinimumSize());
- int min_height = tabstrip_size.height() + toolbar_size.height() +
+ int min_height = delegate_->GetTopInsetInBrowserView() +
+ tabstrip_size.height() + toolbar_size.height() +
bookmark_bar_size.height() + contents_size.height();
int widths[] = {
tabstrip_size.width(),
@@ -532,8 +533,11 @@ void BrowserViewLayout::LayoutContentsSplitView(int top, int bottom) {
void BrowserViewLayout::UpdateTopContainerBounds() {
gfx::Rect top_container_bounds(top_container_->GetPreferredSize());
- // If the immersive mode controller is animating the top-of-window views,
- // part of the top container may be offscreen.
+ // If the immersive mode controller is animating the top container, it may be
+ // partly offscreen. The top container is positioned relative to the top of
+ // the client view instead of relative to GetTopInsetInBrowserView() because
+ // the top container paints parts of the frame (title, window controls) during
+ // an immersive reveal.
top_container_bounds.set_y(
immersive_mode_controller_->GetTopContainerVerticalOffset(
top_container_bounds.size()));
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698