Enable immersive fullscreen for hosted apps part 2

chrome/browser/ui/views/frame/immersive_mode_controller_ash.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_IMMERSIVE_MODE_CONTROLLER_ASH_H_
 #define CHROME_BROWSER_UI_VIEWS_FRAME_IMMERSIVE_MODE_CONTROLLER_ASH_H_
 
 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
 
 #include "ash/wm/immersive_fullscreen_controller.h"
 #include "ash/wm/window_state_observer.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "ui/gfx/rect.h"
 
 namespace aura {
 class Window;
 }
 
 class ImmersiveModeControllerAsh

[James Cook, 2013/11/25 19:09:20]

Random thought for a future CL: It would be nice to have a header file somewhere
that has a mini-design comment, explaining the difference between immersive
fullscreen, tab fullscreen, etc. and then pointers to it in
ImmersiveModeController, maybe here, etc.

Kinda like histogram.h but not a 5-page discourse. :-)

     : public ImmersiveModeController,
       public ash::ImmersiveFullscreenController::Delegate,
       public ash::wm::WindowStateObserver,
       public content::NotificationObserver {
  public:
   ImmersiveModeControllerAsh();
   virtual ~ImmersiveModeControllerAsh();
 
   // ImmersiveModeController overrides:
   virtual void Init(BrowserView* browser_view) OVERRIDE;
@@ skipping 18 matching lines @@
   // Updates the browser root view's layout including window caption controls.
   void LayoutBrowserRootView();
 
   // Shrinks or expands the touch hit test by updating insets for the render
   // window depending on if top_inset is positive or negative respectively.
   // Used to ensure that touch events at the top of the screen go to the top
   // container so a slide gesture can be generated when the content window is
   // consuming all touch events sent to it.
   void SetRenderWindowTopInsetsForTouch(int top_inset);
 
-  // Sets whether the tab strip is painted in a short "light bar" style.
-  void SetTabIndicatorsVisible(bool visible);
+  // Updates whether the tab strip is painted in a short "light bar" style.
+  // Returns true if the visibility of the tab indicators has changed.
+  bool UpdateTabIndicators();
 
   // ImmersiveFullscreenController::Delegate overrides:
   virtual void OnImmersiveRevealStarted() OVERRIDE;
   virtual void OnImmersiveRevealEnded() OVERRIDE;
   virtual void OnImmersiveFullscreenExited() OVERRIDE;
   virtual void SetVisibleFraction(double visible_fraction) OVERRIDE;
   virtual std::vector<gfx::Rect> GetVisibleBoundsInScreen() const OVERRIDE;
 
   // ash::wm::WindowStateObserver override:
   virtual void OnWindowShowTypeChanged(
@@ skipping 28 matching lines @@
   // the top-of-window views are not revealed regardless of
   // |use_tab_indicators_|.
   double visible_fraction_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ImmersiveModeControllerAsh);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_FRAME_IMMERSIVE_MODE_CONTROLLER_ASH_H_