src/effects/SkTileImageFilter.cpp - Issue 83343003: Adding more validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkTileImageFilter.cpp

Issue 83343003: Adding more validation (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Attempting to upload yet again Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkTileImageFilter.cpp

diff --git a/src/effects/SkTileImageFilter.cpp b/src/effects/SkTileImageFilter.cpp

index 8cc096cf370043b4ecbd813bb171305cef43126f..d15f3d97099512f787e512d2e92fc1adec40d539 100644

--- a/src/effects/SkTileImageFilter.cpp

+++ b/src/effects/SkTileImageFilter.cpp

@@ -54,7 +54,8 @@ bool SkTileImageFilter::onFilterImage(Proxy* proxy, const SkBitmap& src, const S

return true;

}

-SkTileImageFilter::SkTileImageFilter(SkFlattenableReadBuffer& buffer) : INHERITED(buffer) {

+SkTileImageFilter::SkTileImageFilter(SkFlattenableReadBuffer& buffer)

+ : INHERITED(buffer, SkImageFilter::kOneInput) {

buffer.readRect(&fSrcRect);

buffer.readRect(&fDstRect);

buffer.validate(SkIsValidRect(fSrcRect) && SkIsValidRect(fDstRect));