Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 83343002: Remove usage of deprecated APIs from cctests (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove usage of deprecated APIs from cctests Also turn on deprecation warnings BUG=v8:3023 R=svenpanne@chromium.org, dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1427 lines, -1003 lines) Patch
M test/cctest/cctest.h View 4 chunks +8 lines, -5 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/test-accessors.cc View 11 chunks +37 lines, -22 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 90 chunks +242 lines, -193 lines 0 comments Download
M test/cctest/test-compiler.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 38 chunks +251 lines, -160 lines 0 comments Download
M test/cctest/test-debug.cc View 116 chunks +572 lines, -397 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-decls.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 25 chunks +26 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 8 chunks +12 lines, -9 lines 0 comments Download
M test/cctest/test-lockers.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-object-observe.cc View 20 chunks +77 lines, -46 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 6 chunks +30 lines, -24 lines 0 comments Download
M test/cctest/test-serialize.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-strings.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 14 chunks +102 lines, -82 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-weaksets.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-22 12:03:57 UTC) #1
Sven Panne
LGTM (rubberstamped)
7 years, 1 month ago (2013-11-22 12:15:58 UTC) #2
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-22 12:43:37 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r18011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698